Skip to content

chore: enforce pnpm 11#1170

Merged
piecyk merged 2 commits into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11
Jun 30, 2026
Merged

chore: enforce pnpm 11#1170
piecyk merged 2 commits into
TanStack:mainfrom
Sheraff:opencode/enforce-pnpm-11

Conversation

@Sheraff

@Sheraff Sheraff commented May 21, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Adds engines.pnpm >=11.9.0 to TanStack/virtual.

Scenario Result
pnpm@11+ install Allowed
pnpm@11+ run ... Allowed
pnpm@9 install Blocked by engines.pnpm
pnpm@9 run ... Blocked by engines.pnpm
pnpm@10 install with default pnpm version management Usually hands off to packageManager and runs as the declared pnpm version
pnpm@10 run ... with default pnpm version management Usually hands off to packageManager and runs as the declared pnpm version
pnpm@10 install with version handoff disabled Blocked by engines.pnpm
pnpm@10 run ... with version handoff disabled Blocked by engines.pnpm
pnpm@9/10 list Not blocked
pnpm@9/10 exec ... Not blocked
Field What It Does
packageManager Helps tools/newer pnpm select or hand off to the declared pnpm version
engines.pnpm: ">=11.0.0" Fails important project workflows when an older pnpm is actually executing them
engines.pnpm Does not intercept every pnpm subcommand

Summary by CodeRabbit

  • Chores
    • Updated the pnpm version requirement to >=11.9.0, aligning with the existing pnpm@11.9.0 package manager setting.

@coderabbitai

coderabbitai Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b221ed63-99e7-42a4-8333-766dc04672ad

📥 Commits

Reviewing files that changed from the base of the PR and between 284680f and f087489.

📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json
📝 Walkthrough

Walkthrough

This PR adds a pnpm version constraint to the project configuration, specifying that pnpm 11.9.0 or higher is required.

Changes

pnpm version requirement

Layer / File(s) Summary
pnpm engine version constraint
package.json		 Added engines.pnpm field specifying minimum pnpm version as >=11.9.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped through the config with glee,
Pnpm 11.9 is the key.
A tiny gate, so neat and bright,
Keeps our burrow humming right.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change, but it misses the required template sections for Changes, Checklist, and Release Impact. Rewrite the PR description using the repository template and fill in the Changes, Checklist, and Release Impact sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: enforcing pnpm 11 via package metadata.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit f087489

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 58s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 17s View ↗

☁️ Nx Cloud last updated this comment at 2026-06-30 14:45:31 UTC

@pkg-pr-new

pkg-pr-new Bot commented May 21, 2026 •
edited
Loading

Copy link
Copy Markdown
More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@1170

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@1170

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@1170

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@1170

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@1170

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@1170

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@1170

commit: f087489

piecyk
piecyk reviewed Jun 30, 2026
View reviewed changes

@piecyk piecyk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sheraff, can you rebase with master and bump the version?

Comment thread package.json Outdated
},
"packageManager": "pnpm@11.1.0",
"engines": {
"pnpm": ">=11.0.0"

@piecyk piecyk Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pnpm": ">=11.0.0"
"pnpm": ">=11.9.0"

@piecyk piecyk merged commit e8c0096 into TanStack:main Jun 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piecyk piecyk piecyk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sheraff @piecyk